New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAM-2079 Added "N" to regexs for illumina metadata #2080

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@pauldwolfe
Copy link
Contributor

pauldwolfe commented Nov 6, 2018

No description provided.

Paul Wolfe added some commits Jun 28, 2018

Paul Wolfe Paul Wolfe
[ADAM-1697] Expand illumina metadata regex
Now includes possible index sequence characters.
Paul Wolfe Paul Wolfe
[ADAM-1697] Expand illumina metadata regex
Fix typo in unit test.
Paul Wolfe Paul Wolfe
Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	adam-core/src/test/scala/org/bdgenomics/adam/rdd/fragment/FragmentRDDSuite.scala
Paul Wolfe Paul Wolfe
ADAM-2079 Adds 'N' to the regex for both the input format and record
converter. Also changes the test data to include an 'N'
@AmplabJenkins

This comment has been minimized.

Copy link

AmplabJenkins commented Nov 6, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2853/

Build result: FAILURE

GitHub pull request #2080 of commit 5ad4941 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2080/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 4b1eecb # timeout=10Checking out Revision 4b1eecb (origin/pr/2080/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 4b1eecb908feae293c1b1eabd1bb44636705dc30First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh

This comment has been minimized.

Copy link
Member

heuermh commented Nov 7, 2018

This pull request will need some git surgery to remove the conflicts; can you try to rebase & squash from the latest git HEAD?

@pauldwolfe

This comment has been minimized.

Copy link
Contributor

pauldwolfe commented Nov 7, 2018

Yeah no problem, I might just recreate my fork and redo the change, and abandon this PR.

@pauldwolfe pauldwolfe closed this Nov 7, 2018

@heuermh heuermh added this to the 0.25.0 milestone Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment