Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename contig to reference #2100

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Dec 11, 2018

Companion pull request to
bigdatagenomics/bdg-formats#43
bigdatagenomics/bdg-formats#154

Some temporary workarounds were necessary for NucleotideContigFragment, which will be removed in
bigdatagenomics/bdg-formats#142
bigdatagenomics/bdg-formats#153

If not clear, this bumps bdg-formats to a SNAPSHOT version, 0.12.0-SNAPSHOT.

@coveralls
Copy link

coveralls commented Dec 11, 2018

Coverage Status

Coverage remained the same at 79.094% when pulling 48f7fca on heuermh:contig-to-reference into a26ee37 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2896/

Build result: FAILURE

GitHub pull request #2100 of commit a371f9f automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2100/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains e17890d # timeout=10Checking out Revision e17890d (origin/pr/2100/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f e17890d5101969801340d3d1e3c17dc947407ef1First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2898/

Build result: FAILURE

GitHub pull request #2100 of commit 47781cf automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2100/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains 756ef68 # timeout=10Checking out Revision 756ef68 (origin/pr/2100/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 756ef687736c19f36bd745ec2be5c839dc2e07ddFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.2,ubuntuADAM-prb ? 2.7.5,2.11,2.2.2,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2899/
Test PASSed.

@heuermh heuermh added this to the 0.26.0 milestone Dec 11, 2018
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2901/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2922/
Test PASSed.

@heuermh
Copy link
Member Author

heuermh commented Jan 6, 2019

This pull request has been out for a month, will merge soon without objection.

@fnothaft fnothaft merged commit 0bd2bb3 into bigdatagenomics:master Jan 11, 2019
@fnothaft
Copy link
Member

Merged! Thanks @heuermh!

@heuermh heuermh deleted the contig-to-reference branch January 12, 2019 00:16
@heuermh
Copy link
Member Author

heuermh commented Jan 12, 2019

Thank you, @fnothaft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants