Update python and R versions. #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmorrow13
reviewed
Feb 21, 2019
adam-python/version.py
Outdated
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| from __future__ import print_function | |||
|
|
|||
| version = '0.25.0a0' | |||
| version = '0.26.0' | |||
There was a problem hiding this comment.
I think this should be '0.26.0a0' after it is pushed to pypi as 0.26.0
There was a problem hiding this comment.
ok, so that is the rough equivalent to 0.27.0-SNAPSHOT then?
There was a problem hiding this comment.
yep! @heuermh the only difference is you have to update the minor version for the "snapshot" everytime you push (ie if you push 0.26.0a1, update it to 0.26.0a2)
|
Test PASSed. |
|
Thank you for the review, @akmorrow13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2089, looks like the same might also be an issue for
adam-python/version.py.Should this be set to the current snapshot version
0.27.0-SNAPSHOTon git head?