Updates to indel realigner to improve performance and accuracy. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.bdgenomics.adam.rdd.ADAMContext._ | ||
| import org.bdgenomics.adam.rdd.variation.ADAMVariationContext._ | ||
| import org.bdgenomics.adam.algorithms.realignmenttarget.IndelRealignmentTarget | ||
| import org.bdgenomics.adam.models.{ |
There was a problem hiding this comment.
I'd vote to switch to ._ when we need to wrap the imports like this.
|
@carlyeks did the update you pointed out; how broadly do you think we should apply that? I.e., do you want me to go and do that on all the files in the PR? |
|
That seems to be the only file that has that (most are up to 3). Other than that, I'm happy with the PR. |
carlyeks
added a commit
that referenced
this pull request
Jul 22, 2014
Updates to indel realigner to improve performance and accuracy.
|
Thanks, @fnothaft! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases the indel realigner target branch on master. I will delete the indel realigner target branch once this PR merges.