New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test suite for FlagStat #552

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@beaunorgeot
Contributor

beaunorgeot commented Jan 23, 2015

Issue #355

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 23, 2015

Can one of the admins verify this patch?

AmplabJenkins commented Jan 23, 2015

Can one of the admins verify this patch?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 23, 2015

Member

Jenkins, add to whitelist and test this please.

Member

fnothaft commented Jan 23, 2015

Jenkins, add to whitelist and test this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 23, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/548/

Build result: FAILURE

GitHub pull request #552 of commit a7b5775 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision d7bae96 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d7bae96 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Jan 23, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/548/

Build result: FAILURE

GitHub pull request #552 of commit a7b5775 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision d7bae96 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d7bae96 > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 23, 2015

Member

A few small nits, but otherwise looks good to me! Thanks for putting this together, and I look forward to getting it merged in.

Member

fnothaft commented Jan 23, 2015

A few small nits, but otherwise looks good to me! Thanks for putting this together, and I look forward to getting it merged in.

@massie

This comment has been minimized.

Show comment
Hide comment
@massie

massie Jan 23, 2015

Member

Thanks @beaunorgeot. We always like to see more test coverage. 👍

Member

massie commented Jan 23, 2015

Thanks @beaunorgeot. We always like to see more test coverage. 👍

@beaunorgeot

This comment has been minimized.

Show comment
Hide comment
@beaunorgeot

beaunorgeot Jan 24, 2015

Contributor

Hi Guys, all requested changes/additions have been added. We're excited to be a part of ADAM! Keep us posted if there are further issues

Contributor

beaunorgeot commented Jan 24, 2015

Hi Guys, all requested changes/additions have been added. We're excited to be a part of ADAM! Keep us posted if there are further issues

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 24, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/553/

Build result: ABORTED

GitHub pull request #552 of commit 6dd4357 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision 598bd9f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 598bd9f > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result ABORTEDADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Jan 24, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/553/

Build result: ABORTED

GitHub pull request #552 of commit 6dd4357 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision 598bd9f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 598bd9f > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result ABORTEDADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2015

Member

Jenkins, retest this please.

Member

fnothaft commented Jan 24, 2015

Jenkins, retest this please.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jan 24, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/554/

Build result: FAILURE

GitHub pull request #552 of commit 6dd4357 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision 598bd9f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 598bd9f > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

AmplabJenkins commented Jan 24, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/554/

Build result: FAILURE

GitHub pull request #552 of commit 6dd4357 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/552/merge^{commit} # timeout=10Checking out Revision 598bd9f (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 598bd9f > git rev-list d8e02d9 # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2015

Member

This just needs this:

./scripts/format-source

I will do that manually and commit.

Member

fnothaft commented Jan 24, 2015

This just needs this:

./scripts/format-source

I will do that manually and commit.

fnothaft added a commit that referenced this pull request Jan 24, 2015

Merge pull request #552 from beaunorgeot/flag_stat_suite
[ADAM-355] Create test suite for FlagStat
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2015

Member

Merged manually by f109a97.

Member

fnothaft commented Jan 24, 2015

Merged manually by f109a97.

@fnothaft fnothaft closed this Jan 24, 2015

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft
Member

fnothaft commented Jan 24, 2015

Thanks @beaunorgeot!

@beaunorgeot

This comment has been minimized.

Show comment
Hide comment
@beaunorgeot

beaunorgeot Jan 24, 2015

Contributor

Happy to be contributing. Lots of credit to @ansalaza on this one

Contributor

beaunorgeot commented Jan 24, 2015

Happy to be contributing. Lots of credit to @ansalaza on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment