Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for wildcard exclusion maven warnings #67

Merged
merged 1 commit into from Jan 28, 2014

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jan 28, 2014

Maven version 3.1 issues warnings against wildcard dependency exclusions

$ mvn install
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.berkeley.cs.amplab.adam:adam-format:jar:0.6.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ edu.berkeley.cs.amplab.adam:adam-parent:0.6.1-SNAPSHOT, /Users/xxx/working/adam/pom.xml, line 233, column 37
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ edu.berkeley.cs.amplab.adam:adam-parent:0.6.1-SNAPSHOT, /Users/xxx/working/adam/pom.xml, line 237, column 37
...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.berkeley.cs.amplab.adam:adam-cli:jar:0.6.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ edu.berkeley.cs.amplab.adam:adam-parent:0.6.1-SNAPSHOT, /Users/xxx/working/adam/pom.xml, line 233, column 37
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ edu.berkeley.cs.amplab.adam:adam-parent:0.6.1-SNAPSHOT, /Users/xxx/working/adam/pom.xml, line 237, column 37
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.berkeley.cs.amplab.adam:adam-parent:pom:0.6.1-SNAPSHOT
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ line 233, column 37
[WARNING] 'dependencyManagement.dependencies.dependency.exclusions.exclusion.artifactId' for org.apache.hadoop:hadoop-client:jar with value '*' does not match a valid id pattern. @ line 237, column 37
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
[INFO] ------------------------------------------------------------------------

These warnings are slated to be removed in version Maven 3.2, but it may still be worth removing the wildcards at this point.

Allow wildcards in dependency exclusions
http://jira.codehaus.org/browse/MNG-3832

I also noticed that artifacts from org.sonatype.sisu.inject are being excluded even though after removing the wildcard exclusion none are shown with

$ mvn dependency:tree -Ddetail=true | grep sisu -

and none are listed by the maven-shade-plugin when building the jar.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/52/

massie added a commit that referenced this pull request Jan 28, 2014
fix for wildcard exclusion maven warnings
@massie massie merged commit 0a579bd into bigdatagenomics:master Jan 28, 2014
@massie
Copy link
Member

massie commented Jan 28, 2014

Thanks, Michael!

@heuermh heuermh deleted the wildcard-exclusions branch January 28, 2014 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants