New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom ReferenceRegion hashcode #819

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@arahuja
Contributor

arahuja commented Sep 8, 2015

Fixes #817

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/898/

Build result: FAILURE

GitHub pull request #819 of commit d8aeec9 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/819/merge^{commit} # timeout=10 > git branch -a --contains 5703e8407d7e8a35f1d3daa112957eebef74e51c # timeout=10 > git rev-parse remotes/origin/pr/819/merge^{commit} # timeout=10Checking out Revision 5703e8407d7e8a35f1d3daa112957eebef74e51c (origin/pr/819/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 5703e8407d7e8a35f1d3daa112957eebef74e51cFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

AmplabJenkins commented Sep 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/898/

Build result: FAILURE

GitHub pull request #819 of commit d8aeec9 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/819/merge^{commit} # timeout=10 > git branch -a --contains 5703e8407d7e8a35f1d3daa112957eebef74e51c # timeout=10 > git rev-parse remotes/origin/pr/819/merge^{commit} # timeout=10Checking out Revision 5703e8407d7e8a35f1d3daa112957eebef74e51c (origin/pr/819/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 5703e8407d7e8a35f1d3daa112957eebef74e51cFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@arahuja

This comment has been minimized.

Show comment
Hide comment
@arahuja

arahuja Sep 8, 2015

Contributor

Looks the fields can be null sometimes - adding a null check

Contributor

arahuja commented Sep 8, 2015

Looks the fields can be null sometimes - adding a null check

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/899/

Build result: FAILURE

GitHub pull request #819 of commit 4c8d1f8 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/819/merge^{commit} # timeout=10 > git branch -a --contains 86b1ddd0d0814c287b671dc1a02be6642b8f7eab # timeout=10 > git rev-parse remotes/origin/pr/819/merge^{commit} # timeout=10Checking out Revision 86b1ddd0d0814c287b671dc1a02be6642b8f7eab (origin/pr/819/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 86b1ddd0d0814c287b671dc1a02be6642b8f7eabFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

AmplabJenkins commented Sep 8, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/899/

Build result: FAILURE

GitHub pull request #819 of commit 4c8d1f8 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/819/merge^{commit} # timeout=10 > git branch -a --contains 86b1ddd0d0814c287b671dc1a02be6642b8f7eab # timeout=10 > git rev-parse remotes/origin/pr/819/merge^{commit} # timeout=10Checking out Revision 86b1ddd0d0814c287b671dc1a02be6642b8f7eab (origin/pr/819/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 86b1ddd0d0814c287b671dc1a02be6642b8f7eabFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.10,1.4.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.4.1,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Sep 8, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/900/
Test PASSed.

AmplabJenkins commented Sep 8, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/900/
Test PASSed.

override def hashCode: Int = {
var result = 37
result = 41 * result + (if (referenceName != null) referenceName.hashCode else 0)
result = 41 * result + (if (start != null) start.hashCode else 0)

This comment has been minimized.

@laserson

laserson Sep 8, 2015

Contributor

Does this mean that two ReferenceRegion objects that differ only in that one has start=0 and the other has start=null would have the same hashCode?

@laserson

laserson Sep 8, 2015

Contributor

Does this mean that two ReferenceRegion objects that differ only in that one has start=0 and the other has start=null would have the same hashCode?

This comment has been minimized.

@laserson

laserson Sep 8, 2015

Contributor

oh, sorry, I read that as start rather than start.hashCode.

@laserson

laserson Sep 8, 2015

Contributor

oh, sorry, I read that as start rather than start.hashCode.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 12, 2015

Member

Thanks @arahuja! I've manually committed this as c4b23e0.

Member

fnothaft commented Sep 12, 2015

Thanks @arahuja! I've manually committed this as c4b23e0.

@fnothaft fnothaft closed this Sep 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment