Instrumentation for RegressPhenotypes #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
I was waiting on a successful build for #12 before adding other pull requests to Jenkins. |
heuermh
requested changes
Feb 24, 2017
| // Log the results | ||
| logResults(associations, sc) | ||
| } | ||
|
|
||
| def print_metrics_to_cmdline(metricsListener: MetricsListener) { |
| @@ -95,6 +97,9 @@ class RegressPhenotypesArgs extends Args4jBase { | |||
|
|
|||
| @Args4jOption(required = false, name = "-oneTwo", usage = "If cases are 1 and controls 2 instead of 0 and 1") | |||
| var oneTwo = false | |||
|
|
|||
| @Args4jOption(required = false, name = "-time", usage = "Prints out the timing information for RegressPhenotypes to commandline.") | |||
There was a problem hiding this comment.
in ADAM we use -print_metrics for this, which comes from bdg-utils
Or am I missing the use case here?
| @@ -107,6 +112,11 @@ class RegressPhenotypes(protected val args: RegressPhenotypesArgs) extends BDGSp | |||
| val a = args.oneTwo | |||
| // println(s"\n\n\n\n\n\n oneTwo: $a \n\n\n\n\n\n\n\n") | |||
|
|
|||
| import Timers._ | |||
| Metrics.initialize(sc) | |||
There was a problem hiding this comment.
this is also handled in bdg-utils for the -print_metrics argument
|
Jenkins, add to whitelist |
p-yang
pushed a commit
to p-yang/gnocchi
that referenced
this pull request
Apr 28, 2017
Ports in incremental update refactor code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in instrumentation for RegressPhenotypes which can be ported to other section of code when the need arises.