updated pileup tutorial and supporting documents for genotype example #501
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Thanks @abhim00! I dropped some comments.
Can you also add unit tests (see https://github.com/bigdatagenomics/mango/blob/master/mango-viz/bdgenomics/mango/pileup/test/test_application.py)
docs/jupyterWidgets/usage.rst
Outdated
| .. code:: python | ||
|
|
||
| # make genotype track | ||
| tracks=[Track(viz="features", label="my Features", source=pileup.sources.VcfDataSource(./data/genodata.v3.vcf))] |
There was a problem hiding this comment.
see comment above. Also, I dont think this would work because the filepath is not in quotes
There was a problem hiding this comment.
This is a feature visualization, not genotypes
There was a problem hiding this comment.
will fix this... was an oversight
|
I made the changes, hope this works. |
docs/jupyterWidgets/usage.rst
Outdated
| .. code:: python | ||
|
|
||
| # make genotype track | ||
| tracks=[Track(viz="genotypes", label="my Genotypes", source=pileup.sources.VcfDataSource("/path/to_vcf.vcf"))] |
There was a problem hiding this comment.
"/path/to_vcf.vcf" -> "<path_to_file>/my_vcf.vcf"
|
Thanks @abhim00 just one minor change other than that looks good! |
|
Jenkins, test this please. |
|
fixed that issue ! |
|
Test FAILed. |
|
Jenkins, retest this please. |
|
Test PASSed. |
|
Thanks @abhim00 ! |
No description provided.