Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch past grants search on live environment #1426

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Launch past grants search on live environment #1426

merged 1 commit into from
Nov 6, 2018

Conversation

mattandrews
Copy link
Contributor

When this is ready to go live we can merge it.

davidrapson
davidrapson approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@davidrapson davidrapson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

As a note using feature flags here is definitely nicer than using App.isNotProduction or draft: true in a bunch of places.

@mattandrews mattandrews merged commit 9718931 into master Nov 6, 2018
@mattandrews mattandrews deleted the launch-past-grants-search branch November 6, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidrapson davidrapson davidrapson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattandrews @davidrapson