Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pages to CMS #2932

Merged
merged 12 commits into from
Feb 10, 2020
Merged

Move pages to CMS #2932

merged 12 commits into from
Feb 10, 2020

Conversation

mattandrews
Copy link
Contributor

Fixes #1731

This moves the following URLs/pages to the CMS:

I've created all of the above pages in the relevant sections in the CMS – the Digital Fund one will work as soon as this PR is merged, but the others will need vanity URLs updating (also in the CMS) to point to their new destinations (eg. the Wales/NI pages will now live under /funding).

Feels good to get these things out of the app and into the CMS!

Copy link
Contributor

@davidrapson davidrapson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Wonderful work. Only bit I couldn't see was redirects for /funding/under10k to /funding/under-10k and the same for over 10k

@@ -198,196 +198,15 @@ toplevel:
over10k:
short: Apply for funding over £10,000
long: Learn how to apply for funding over £10,000
northernIreland:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

controllers/__snapshots__/aliases.test.js.snap Outdated Show resolved Hide resolved
@mattandrews mattandrews changed the title Move pages to cms Move pages to CMS Feb 7, 2020
Copy link
Contributor

@davidrapson davidrapson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattandrews Latest changes look great. So many deletions!

const { isWelsh } = require('../../common/urls');
const contentApi = require('../../common/content-api');

function staticPage({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@mattandrews mattandrews merged commit 103df15 into master Feb 10, 2020
@mattandrews mattandrews deleted the move-pages-to-cms branch February 10, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all remaining content pages into the CMS (within reason)
2 participants