Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio flags are not shown #107

Closed
paulvt opened this issue Dec 11, 2011 · 9 comments
Closed

Audio flags are not shown #107

paulvt opened this issue Dec 11, 2011 · 9 comments

Comments

@paulvt
Copy link

paulvt commented Dec 11, 2011

Hey again,

Thanks for the quick fix earlier and for this amazing skin!

Since about 445c6f8, I have not seen the audio flags (year, codec type, etc.) in the MusicOSD in fullscreen mode. This results in a gap to the left and right next of the rating.
See also this screenshot.

I also remember the frequency, bitrate and number of channels being positioned next to the other audio flags, but they have now moved under the (elapsed) time. Is this an intentional move, is it a fallback, or am I just remembering incorrectly? :)

@BigNoid
Copy link
Owner

BigNoid commented Dec 12, 2011

Codec flag should still be there. I shuffled around some of the things to be able to make it look like this: http://youtu.be/fkG2FkfmPyA

This will result in somewhat empty screen if there is no recordlabel flag and artist logo available, but imo still looks good. Obviously without the codec flag it looks too empty and that is not the intention. Could you check the codec flag in that file, maybe the flag is just missing.

@paulvt
Copy link
Author

paulvt commented Dec 12, 2011

Ah ok, so you made room for other things. I have mostly music of unknown artists and record labels, hence the emptiness ;)

I have mostly FLAC files. Also the case for the one in the screenshot. So, maybe it's just flac that's not working. I am not sure what you mean with checking the codec flag "in the file"? Do you mean to query XBMC somehow to find out what it thinks it is?

@BigNoid
Copy link
Owner

BigNoid commented Dec 12, 2011

My flac files do show the codec flag. Yeah I mean to find out what codec is used by xbmc. To find out:
Update Nox to latest git.
Play the file and enter music viz.
Press "O" and you will see the codec name.

@paulvt
Copy link
Author

paulvt commented Dec 12, 2011

All right. So it says: Audio codec: FLAC.

@paulvt
Copy link
Author

paulvt commented Dec 12, 2011

I found this close to the time I started playing in the logs:

17:55:41 T:140448375437216   ERROR: unmatched parentheses in PlayMedia($INFO
17:55:41 T:140448375437216   ERROR: unmatched parentheses in )
17:55:41 T:140448375437216   ERROR: Error evaluating boolean expression PlayMedia($INFO[Container(8000).ListItem.Property(Trailer)])
17:55:43 T:140448375437216   ERROR: Texture manager unable to load file: /home/media/Music/Ørjan Nilsen/Ørjan Nilsen - In My Opinion/fanart.jpg

@BigNoid
Copy link
Owner

BigNoid commented Dec 12, 2011

That is an unrelated error (was from the home widget) and it's normal that it tries to load fanart.jpg.
I think I know what's wrong. you are running Linux and then it doesn't load flac.png because the codec name is in uppercase. i don't have this problem on my Linux build because I build textures.xbt and with that uppercase/lowercase doesn't matter. Will change the flag name to FLAC.png.

@paulvt
Copy link
Author

paulvt commented Dec 12, 2011

Then it's the same for mp3, it also states: Audio codec: MP3, and possible more (vorbis?)

@BigNoid
Copy link
Owner

BigNoid commented Dec 12, 2011

Fixed in 4155ed6
Btw, this shouldn't be a problem when the skin is officially released as the repo builds textures.xbt automatically.

@BigNoid BigNoid closed this as completed Dec 12, 2011
@paulvt
Copy link
Author

paulvt commented Dec 12, 2011

Ok. Yes, that was the fix. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants