Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperscript debugger UI form error on being element scoped in set Feature #hdb #breakpoint #set #feature #539

Open
charles-prof opened this issue May 20, 2024 · 6 comments
Open

Hyperscript debugger UI form error on being element scoped in set Feature #hdb #breakpoint #set #feature #539

charles-prof opened this issue May 20, 2024 · 6 comments

Comments

@charles-prof
Copy link

Calling breakpoint causes this error whether inline or on a hyperscript function (def)

My code and script order

<body>
		<h1>Hyperscript Playground</h1>
		<main _="init fetch /home.html then stopAndReveal(it) put it into me"></main>
		<script type="text/hyperscript">
			def stopAndReveal(it)
			  set :x to it
			  log :x
			  breakpoint
			  return it
			end
		</script>
		<script src="_hyperscript.js"></script>
		<script src="hdb.js"></script>
	</body>

The original error message

hyperscript errors were found on the following element: 
<form id="console-form" data-hist="0" _="on submit\n\t\t\t\tsend …to #console-input.value"> 

 variables declared at the feature level must be element scoped.

				halt default
     ^^

 raiseParseError@http://localhost:8080/_hyperscript.js:1288:25
raiseParseError@http://localhost:8080/_hyperscript.js:1298:20
hyperscriptCoreGrammar/<@http://localhost:8080/_hyperscript.js:4657:28
featureDefinitionWrapper@http://localhost:8080/_hyperscript.js:1234:48
Parser/<@http://localhost:8080/_hyperscript.js:1011:28
parseElement@http://localhost:8080/_hyperscript.js:1153:53
requireElement@http://localhost:8080/_hyperscript.js:1175:31
hyperscriptCoreGrammar/<@http://localhost:8080/_hyperscript.js:4123:42
parseElement@http://localhost:8080/_hyperscript.js:1153:53
parseHyperScript@http://localhost:8080/_hyperscript.js:1306:31
initElement@http://localhost:8080/_hyperscript.js:1958:50
processNode/<@http://localhost:8080/_hyperscript.js:1936:26
forEach@http://localhost:8080/_hyperscript.js:1535:25
processNode@http://localhost:8080/_hyperscript.js:1935:22
HDB.prototype.ui@http://localhost:8080/hdb.js:527:17
HDB.prototype.break@http://localhost:8080/hdb.js:40:9
op@http://localhost:8080/hdb.js:31:18
unifiedEval@http://localhost:8080/_hyperscript.js:1730:40
unifiedExec@http://localhost:8080/_hyperscript.js:1604:37
addCommand/commandDefinitionWrapper/commandElement.execute@http://localhost:8080/_hyperscript.js:1216:40
func@http://localhost:8080/_hyperscript.js:4627:31
op@http://localhost:8080/_hyperscript.js:3362:42
unifiedEval@http://localhost:8080/_hyperscript.js:1730:40
evaluate@http://localhost:8080/_hyperscript.js:3366:40
unifiedEval@http://localhost:8080/_hyperscript.js:1693:46
unifiedExec@http://localhost:8080/_hyperscript.js:1604:37
unifiedExec/<@http://localhost:8080/_hyperscript.js:1627:30
promise callback*unifiedExec@http://localhost:8080/_hyperscript.js:1626:26
addCommand/commandDefinitionWrapper/commandElement.execute@http://localhost:8080/_hyperscript.js:1216:40
handler@http://localhost:8080/_hyperscript.js:4680:40
setTimeout handler*install@http://localhost:8080/_hyperscript.js:4685:35
apply@http://localhost:8080/_hyperscript.js:4134:33
initElement@http://localhost:8080/_hyperscript.js:1960:37
processNode/<@http://localhost:8080/_hyperscript.js:1936:26
forEach@http://localhost:8080/_hyperscript.js:1535:25
processNode@http://localhost:8080/_hyperscript.js:1935:22
browserInit/</<@http://localhost:8080/_hyperscript.js:7577:22
EventListener.handleEvent*ready@http://localhost:8080/_hyperscript.js:7587:26
browserInit/<@http://localhost:8080/_hyperscript.js:7575:26
promise callback*browserInit@http://localhost:8080/_hyperscript.js:7575:10
@http://localhost:8080/_hyperscript.js:12:54
@http://localhost:8080/_hyperscript.js:14:3
_hyperscript.js:1970:33
    initElement http://localhost:8080/_hyperscript.js:1970
    processNode http://localhost:8080/_hyperscript.js:1936
    forEach http://localhost:8080/_hyperscript.js:1535
    processNode http://localhost:8080/_hyperscript.js:1935
    ui http://localhost:8080/hdb.js:527
    break http://localhost:8080/hdb.js:40
    op http://localhost:8080/hdb.js:31
    unifiedEval http://localhost:8080/_hyperscript.js:1730
    unifiedExec http://localhost:8080/_hyperscript.js:1604
    execute http://localhost:8080/_hyperscript.js:1216
    func http://localhost:8080/_hyperscript.js:4627
    op http://localhost:8080/_hyperscript.js:3362
    unifiedEval http://localhost:8080/_hyperscript.js:1730
    evaluate http://localhost:8080/_hyperscript.js:3366
    unifiedEval http://localhost:8080/_hyperscript.js:1693
    unifiedExec http://localhost:8080/_hyperscript.js:1604
    unifiedExec http://localhost:8080/_hyperscript.js:1627
    (Async: promise callback)
    unifiedExec http://localhost:8080/_hyperscript.js:1626
    execute http://localhost:8080/_hyperscript.js:1216
    handler http://localhost:8080/_hyperscript.js:4680
    (Async: setTimeout handler)
    install http://localhost:8080/_hyperscript.js:4685
    apply http://localhost:8080/_hyperscript.js:4134
    initElement http://localhost:8080/_hyperscript.js:1960
    processNode http://localhost:8080/_hyperscript.js:1936
    forEach http://localhost:8080/_hyperscript.js:1535
    processNode http://localhost:8080/_hyperscript.js:1935
    browserInit http://localhost:8080/_hyperscript.js:7577
    (Async: EventListener.handleEvent)
    ready http://localhost:8080/_hyperscript.js:7587
    browserInit http://localhost:8080/_hyperscript.js:7575
    (Async: promise callback)
    browserInit http://localhost:8080/_hyperscript.js:7575
    <anonymous> http://localhost:8080/_hyperscript.js:12
    <anonymous> http://localhost:8080/_hyperscript.js:14
@y2kbugger
Copy link

y2kbugger commented May 20, 2024 •
edited
Loading

Getting this as well on. Tested on versions 0.9.{10,11,12} in the latest chrome and firefox.

This causes the expression evaluation not to work, and the page reloads when hitting enter.

Hitting this the first time trying HBD today, without this issue I would have continued thinking I was doing something wrong with the installation etc.

@charles-prof
Copy link
Author

My intuition "set is ambiguous"

set is implemented as a command and also a feature.

How to differentiate when calling ?

This is being set is called on top level (I think) as a feature

(I tried to use put for temporary workaround - I failed in getting it to work)

@y2kbugger
Copy link

I'm left wondering how no one else noticed this. Surely we are doing something different than others?

Not sure what you mean about the set vs put (unless you are talking about in the HDB implementation. I even hit it on this, when there is no set.

<a href="#" _="on click breakpoint">Click Me</a>

@charles-prof
Copy link
Author

charles-prof commented May 20, 2024 via email

@y2kbugger
Copy link

image

_hyperscript/src/hdb.js

Line 342 in 1e65fb1

end end

Ok you were close on the setCommand vs setFeature thing. An extra end was pushing the set to be parsed as feature.

But how was this mistake committed 2 years ago and only noticed today, by two people within 11 hours? Doesn't anyone use the expression eval feature of hdb?

@charles-prof
Copy link
Author

charles-prof commented May 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@y2kbugger @charles-prof