Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing LegacyVersion causes crash with packaging>=0.22 #1550

Closed
mikkonie opened this issue Dec 8, 2022 · 1 comment
Closed

Missing LegacyVersion causes crash with packaging>=0.22 #1550

mikkonie opened this issue Dec 8, 2022 · 1 comment
Assignees
@mikkonie
Labels
bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Milestone
v0.13.0

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Dec 8, 2022

This started failing in CI. Looks like LegacyVersion has been removed in packaging==0.22.

Instructions for dealing with the breakage are found here. Probably using Version should work? Can't remember off the top of my head why we use LegacyVersion to begin with..
@mikkonie mikkonie added bug Something isn't working environment Issues of dependencies, CI, deployment etc. labels Dec 8, 2022
@mikkonie mikkonie added this to the v0.13.0 milestone Dec 8, 2022
@mikkonie mikkonie self-assigned this Dec 8, 2022
mikkonie added a commit that referenced this issue Dec 8, 2022
@mikkonie
add tests (wip) (#1509), fix packaging use (#1550)
8e18c94
@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 8, 2022

Fixed, to be merged into dev.

@mikkonie mikkonie closed this as completed Dec 8, 2022
mikkonie added a commit that referenced this issue Dec 12, 2022
@mikkonie
add study render table caching (#1509), update rendering (#708, #1550,#…
cd5449a 
…1551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
1 participant
@mikkonie