Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused header parameters from render tables #1551

Closed
mikkonie opened this issue Dec 8, 2022 · 1 comment
Closed

Remove unused header parameters from render tables #1551

mikkonie opened this issue Dec 8, 2022 · 1 comment
Assignees
@mikkonie
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
v0.13.0

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Dec 8, 2022 •
edited
Loading

The config_set and num_col header parametrers are not currently used for anything and, as far as I can tell, have no planned use either.

The latter can only be found in the Vue app example test data. These references should all be removed.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app labels Dec 8, 2022
@mikkonie mikkonie added this to the v0.13.0 milestone Dec 8, 2022
@mikkonie mikkonie self-assigned this Dec 8, 2022
@mikkonie mikkonie changed the title Remove unused config_set parameter in render tables Remove unused config_set parameter from render tables Dec 8, 2022
@mikkonie mikkonie changed the title Remove unused config_set parameter from render tables Remove unused header parameters from render tables Dec 8, 2022
mikkonie added a commit that referenced this issue Dec 8, 2022
@mikkonie
remove unused header parameters (#1551)
9ac4fc5
@mikkonie
Copy link
Contributor Author

mikkonie commented Dec 8, 2022

Done, to be merged.

@mikkonie mikkonie closed this as completed Dec 8, 2022
mikkonie added a commit that referenced this issue Dec 12, 2022
@mikkonie
add study render table caching (#1509), update rendering (#708, #1550,#…
cd5449a 
…1551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
1 participant
@mikkonie