Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluguin not working on Angular Workspace #467

Closed
dianjuar opened this issue Jan 26, 2023 · 6 comments
Closed

Pluguin not working on Angular Workspace #467

dianjuar opened this issue Jan 26, 2023 · 6 comments

Comments

@dianjuar
Copy link
Member

We decided to remove on #454 the Angular E2E tests as required on the Publish CI Pipeline to unblock the issue.

This issue is to keep an eye on Nx for the fix to:

  • Continuing offering support to Angular Workspaces
  • Bring back the Angular E2E tests as mandatory on the publish CI pipeline once it gets solved.
@dianjuar dianjuar pinned this issue Feb 20, 2023
@dianjuar
Copy link
Member Author

The Nx team may not provide stable compatibility with AngularCLI workspaces. See nrwl/nx#14413 (comment).

They recommend using Angular CLI DevKit to make it run on Angular CLI workspaces. That put us in a difficult position; we need to support two workspaces in parallel to be fully compatible and stable with AngularCLI workspaces. That seems challenging due to the amount of work that it would require.

@dianjuar
Copy link
Member Author

@edbzn I would like to have your input on this problem.

@edbzn
Copy link

edbzn commented Mar 28, 2023

@dianjuar I agree, it's already hard to keep compatibility between different Nx versions (even minor versions), so keeping Angular CLI compatibility is very time-consuming and bug-prone. However it depends on your users, are they using more Nx or Angular CLI? If Angular CLI is important for your users you could point to an old ngx-deploy-npm version in your documentation that might still be compatible with Angular CLI, or even provide fixes/updates to your old branches that still run on Angular CLI, but it means managing two branches that run on different technologies, it's not ideal.

@dianjuar
Copy link
Member Author

I am still determining the percentage of users using this plugin in an Angular Workspace, but in a quick look, apparently, more users are using Nx.

If the AngularCLI workspace users are low, I would consider deprecating AngularCLI Workspaces.

For science and fun, I want to create a script based on the GitHub dependent list stats to determine the portion of users on each workspace. That would give an idea of the number of users that would be affected and if it's a good idea to deprecate the AngularCLI Workspaces compatibility.


Recently I saw that the Nx Console is removing its compatibility with AngularCLI workspaces, so I don't see a bad idea doing the same.

@dianjuar
Copy link
Member Author

We can think about a potential plugin name change since the ngx prefix is not relevant anymore.

https://twitter.com/edbzn/status/1689916532221001728

dianjuar added a commit that referenced this issue Nov 24, 2023
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This
decision is motivated by several factors, including the fact that the Nx Devkit no longer supports
compatibility with Angular Workspaces. To offer support, we would have to create a second plugin
that uses AngularDevkit under the hood, which would require considerable effort on the part of our
maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces
is the best way to do that.

BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx
Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that
you should consider. We apologize for any inconvenience this may cause and appreciate your
understanding.

close #467
dianjuar added a commit that referenced this issue Nov 24, 2023
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This
decision is motivated by several factors, including the fact that the Nx Devkit no longer supports
compatibility with Angular Workspaces. To offer support, we would have to create a second plugin
that uses AngularDevkit under the hood, which would require considerable effort on the part of our
maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces
is the best way to do that.

BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx
Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that
you should consider. We apologize for any inconvenience this may cause and appreciate your
understanding.

close #467
This was referenced Jan 16, 2024
@dianjuar
Copy link
Member Author

dianjuar commented Jan 19, 2024

It was closed by #570.

More information in the version 8 release blog post

@dianjuar dianjuar unpinned this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants