Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion error in jpleph.cpp #6

Closed
dekishalay opened this issue Mar 30, 2020 · 3 comments
Closed

Assertion error in jpleph.cpp #6

dekishalay opened this issue Mar 30, 2020 · 3 comments

Comments

@dekishalay
Copy link

Hello!

We've been using this code together with integrat and astcheck (https://www.projectpluto.com/astcheck.htm) to cross-match detected transients to known solar system bodies. As of a few weeks ago, the jpleph.cpp routine started throwing this error:

integrat: jpleph.cpp:328: void interp(interpolation_info*, const double*, const double*, unsigned int, unsigned int, unsigned int, int, double*): Assertion `tc >= -1.' failed.

We're trying to figure out what causes this but don't have a fix yet. Is this a known issue that has a fix?

Thanks for your help,
Kishalay.

@Bill-Gray
Copy link
Owner

Hi Kishalay,

This sounds quite a bit like a problem that was reported to me back in December. It turned out that I'd made some embarrassing mistakes in the code. I fixed those, the gent reporting the problem pulled the changes, rebuilt, reinstalled, and it all worked again.

I would recommend that you do a 'git pull', 'make', 'make install' for the jpl_eph repository. Then in the lunar repository, run 'git pull', 'make', 'make integrat', and 'make install_integrat'. Do that, and I expect all will work correctly.

The odd make sequence is because Integrat is not built by default. Most people are (I am reasonably sure) only using other bits of the lunar repository; I wanted them to be able to build everything they actually wanted without having to bring in the jpl_eph dependency that Integrat has. It is a strange sequence... but run that, and Integrat should be re-built, this time with the fix to my silly mistakes... let me know if you're still seeing problems.

--Bill

@dekishalay
Copy link
Author

Hi Bill,

Thanks, pulling and reinstalling the code did fix the issue!

Regards
Kishalay

@Bill-Gray
Copy link
Owner

My favorite kind of bug : one that I've already fixed... thanks for confirming it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants