This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
✨ Cache download responses #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
wilsonehusin
force-pushed
the
cache-downloads
branch
4 times, most recently
from
af2c7b2
to
dcaf0d0
Compare
wilsonehusin
force-pushed
the
cache-downloads
branch
from
dcaf0d0
to
025c042
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it
Reducing network calls on downloads to speed up user experience. Ironically, this increases disk usage and perhaps adding another thing to be considered in building the solution for #52.
That said, I think this might require some hardening (the cached files are literally HTTP response and therefore items like
checksum.txtcan be seen transparently) thus the feature is toggle-able and disabled by default.bindl purge cache/ Low priority, and I think I'd rather decide on User mode #52 first before adding more code that relies on the pathWhich issue(s) this PR fixes
N/A — spontaneous development.