Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authorization.py - line 400 #36

Closed
harrisjoseph opened this issue Sep 14, 2016 · 3 comments
Closed

authorization.py - line 400 #36

harrisjoseph opened this issue Sep 14, 2016 · 3 comments

Comments

@harrisjoseph
Copy link

harrisjoseph commented Sep 14, 2016 •
edited
Loading

oauth_web_auth_code_grant.request_oauth_tokens_by_response_uri sends out a the client secret with the post request, causing the following error:

OAuthTokenRequestException: error_code: invalid_request, error_description: Public clients can't send a client secret.

Solution - remove the client_secret parameter from this request at authorization.py:400
@harrisjoseph harrisjoseph changed the title authorization.py - line 401 authorization.py - line 400 Sep 14, 2016
@imagineful
Copy link
Contributor

Thanks @VerdigrisReader
Verified this issue, we will fix it in next release. as the workaround, we can either remove the client_secret parameter as you suggested, or we can just set this client_secret to None, thus this parameter will be removed from the request.

@imagineful
Copy link
Contributor

Hi, @VerdigrisReader could you please verify if this issue still exist? I just noticed that something changed from live.com, the client secret is required as I tested from my side.

@imagineful
Copy link
Contributor

close issue. if anything else please feel free to reopen it or open a new issue. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imagineful @harrisjoseph