Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement transforms as dictionaries #26

Closed
raghavmecheri opened this issue Mar 15, 2021 · 0 comments
Closed

Implement transforms as dictionaries #26

raghavmecheri opened this issue Mar 15, 2021 · 0 comments
Assignees
Labels
feature accepted Core team has approved that this is worth pursuing

Comments

@raghavmecheri
Copy link
Contributor

Feature Request

Description of Problem:

Right now, we just pass a single transform object in. This is inconvenient if we want different transforms for train, test, and val, as mentioned in #25.

Potential Solutions:

Rename the transform parameter to transforms and treat it as a dictionary instead. We can then split it within fetch_segmented_dataloaders . We would also want to update our tests to reflect this change + cover the edge case where the transforms parameter is either None or {}

@raghavmecheri raghavmecheri added the feature accepted Core team has approved that this is worth pursuing label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature accepted Core team has approved that this is worth pursuing
Projects
None yet
Development

No branches or pull requests

2 participants