Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure in basisu_enc.h #50

Closed
MarkCallow opened this issue Jul 16, 2019 · 3 comments
Closed

Assertion failure in basisu_enc.h #50

MarkCallow opened this issue Jul 16, 2019 · 3 comments

Comments

@MarkCallow
Copy link
Contributor

When compressing https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/FlightHelmet/glTF/FlightHelmet_baseColor.png the assertion at line 1070 in basisu_enc.h fires.

assert(node.m_var == var_heap.get_top_priority());

However if basisu is compiled without assertions the resulting file appears to be okay at least to casual inspection.

Note that the CMake build, even with CMAKE_BUILD_TYPE set to Debug does not appear to include assertions. I verified this by adding assert(false); just before line 1070. It doesn't fire. Only in my Xcode Debug build are asserts present.

@richgel999
Copy link
Contributor

Ok - I will investigate this. It shouldn't fire, but I would be surprised if this impacts the correctness of the output.

@rokups
Copy link

rokups commented Sep 21, 2019

This also triggers when trying to compress 4096x4096 image using -comp_level 5.

@richgel999
Copy link
Contributor

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants