Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination Correctness #54

Closed
angelhof opened this issue Nov 26, 2020 · 1 comment
Closed

Termination Correctness #54

angelhof opened this issue Nov 26, 2020 · 1 comment
Labels
good first issue! Good for newcomers

Comments

@angelhof
Copy link
Member

Address the issues shown in this script.

They refer to issues with the currect dataflow termination mechanism.

Copied here for completeness:

## This way of fixing the problem suffers from some issues.
##
## - First of all, gathering the children after the end of the graph
##   seems to gather more than just the alive nodes. This could lead
##   to killing some random pid in the system. This could potentially
##   be solved by gathering all pids incrementally.
##
## - In addition, this way of getting the last pid does not work if
##   there is more than one output. (This is never the case in our
##   tests, but could be.
##
## - Finally, it is not local, since all of the monitoring happens
##   globally. Ideally, it should be done by a wrapper in each -
##   node. The wrapper should monitor if the node dies, and if so it -
##   should send SIGPIPE to all its producers.
@angelhof angelhof added the good first issue! Good for newcomers label Nov 26, 2020
@angelhof
Copy link
Member Author

Superseded by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue! Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant