Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit can't mkdir on an existing file #18

Closed
ezrizhu opened this issue Jun 20, 2023 · 1 comment · Fixed by #83
Closed

commit can't mkdir on an existing file #18

ezrizhu opened this issue Jun 20, 2023 · 1 comment · Fixed by #83
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@ezrizhu
Copy link
Collaborator

ezrizhu commented Jun 20, 2023

try/try

Line 129 in adc117d

mkdir "${local_file}"

Above line fails if directory already exists

touch x
echo 'rm x; mkdir x; touch x/y' > test.sh
./try bash test.sh
mkdir: cannot create directory ‘/home/ubuntu/trymkdir/x’: File exists
couldn't commit /tmp/tmp.qT6BjMKMLb/upperdir/home/ubuntu/trymkdir/x
@mgree
Copy link
Contributor

mgree commented Jun 24, 2023

The correct solution here is to delete x before calling mkdir when committing. We should change the summary to highlight this (i.e., the change is "delete x and then create all this other stuff").

@mgree mgree added enhancement New feature or request good first issue Good for newcomers labels Jun 24, 2023
@angelhof angelhof self-assigned this Jun 28, 2023
@angelhof angelhof added this to the try 0.2 milestone Jun 28, 2023
@angelhof angelhof added bug Something isn't working and removed enhancement New feature or request labels Jun 28, 2023
@angelhof angelhof linked a pull request Jun 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants