Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact change watcher support to Ghidra #16

Closed
mahaloz opened this issue Jan 4, 2024 · 3 comments · Fixed by #37
Closed

Add artifact change watcher support to Ghidra #16

mahaloz opened this issue Jan 4, 2024 · 3 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request ghidra

Comments

@mahaloz
Copy link
Member

mahaloz commented Jan 4, 2024

We need to support sending out a notification from the Interface when a user changes an Artifact in Ghidra (like renaming a function). If we do this, we will be much closer to being ready to port BinSync proper to LibBS and for decomp2dbg.

Previous Work

I implemented some of this in Java: https://github.com/mahaloz/decomp2dbg/blob/3a830e756f3081459c0389bead498b4416288a55/decompilers/d2d_ghidra/src/main/java/decomp2dbg/D2DPlugin.java#L234

I also documented doing some of the Python port in this issue:
justfoxing/ghidra_bridge#72 (comment)

This issue can be closed if we get to minimum support, which, in my mind, supports the decomp2dbg use case.

@Exiled1
Copy link

Exiled1 commented Jan 4, 2024

What still needs to get done in terms of remaining artifacts?

@mahaloz
Copy link
Member Author

mahaloz commented Jan 5, 2024

@Exiled1 I haven't touched that code in a hot minute, so I'm unsure. What I remember about that code I wrote was that it only worked for d2d, specifically to know when any component of decompilation changed. It needs significant edits.

@mahaloz mahaloz added the ghidra label Jan 30, 2024
@mahaloz
Copy link
Member Author

mahaloz commented Feb 26, 2024

@Flipout50, I forgot that this issue is critical to full BinSync support of Ghidra. In BinSync, you still have to manually push every change you make in Ghidra. This should probably be our top priority for now, getting some support for callback-based changed in Ghidra.

@Flipout50 Flipout50 self-assigned this Feb 26, 2024
@mahaloz mahaloz linked a pull request Apr 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ghidra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants