Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Subscriber rate limiting #633

Merged
merged 35 commits into from
Feb 26, 2023
Merged

WIP: Subscriber rate limiting #633

merged 35 commits into from
Feb 26, 2023

Commits on Feb 14, 2023

  1. Use visitor instead of UserID in topicSubscription

    @karmanyaahm
    karmanyaahm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d686e1e View commit details
    Browse the repository at this point in the history

  2. Keep track of lastVisitor to a topic

    @karmanyaahm
    karmanyaahm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    28b654a View commit details
    Browse the repository at this point in the history

  3. Fix m.Expires and prune stale topics based on lastVisitorExpires

    @karmanyaahm
    karmanyaahm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fb2fa4c View commit details
    Browse the repository at this point in the history

  4. Bill to visitor and set TTL in response

    @karmanyaahm
    karmanyaahm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6bfe4a9 View commit details
    Browse the repository at this point in the history

  5. only log expiry if applicable

    @karmanyaahm
    karmanyaahm committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7c5b9c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. remove ttl

    @karmanyaahm
    karmanyaahm committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c6b64df View commit details
    Browse the repository at this point in the history

  2. remove TTL, will make a seperate PR

    @karmanyaahm
    karmanyaahm committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b9badee View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Suggested changes 

    - https://github.com/binwiederhier/ntfy/pull/609/files/b9badee6dbb4d43d6f1abee2f433e7113bb86ab8#r1111115151
- https://github.com/binwiederhier/ntfy/pull/609/files/b9badee6dbb4d43d6f1abee2f433e7113bb86ab8#r1111114771
    @karmanyaahm
    karmanyaahm committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    36685e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. rate limiting impl 2.0?

    @karmanyaahm
    karmanyaahm committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1655f58 View commit details
    Browse the repository at this point in the history

  2. Use mutexes in topic

    @karmanyaahm
    karmanyaahm committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    bc3d897 View commit details
    Browse the repository at this point in the history

  3. rename lastVisitor to vRate

    @karmanyaahm
    karmanyaahm committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0e4044b View commit details
    Browse the repository at this point in the history

  4. limitRequestsWithTopic

    @karmanyaahm
    karmanyaahm committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ce7d447 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Merge branch 'main' into user-account

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    4ab4503 View commit details
    Browse the repository at this point in the history

  2. Add test, fails

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    29340e7 View commit details
    Browse the repository at this point in the history

  3. Working test

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    21b27b5 View commit details
    Browse the repository at this point in the history

  4. Polish a little

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    bdeec4d View commit details
    Browse the repository at this point in the history

  5. More tests; Discovered a bug with the response codes

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    483410c View commit details
    Browse the repository at this point in the history

  6. More todos

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    0c3d832 View commit details
    Browse the repository at this point in the history

  7. Release notes

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    697c09e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into vrate

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ede9579 View commit details
    Browse the repository at this point in the history

  9. Ensure we return 429s for Matrix endpoints too; return proper error c… 

    …odes
    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    57e1104 View commit details
    Browse the repository at this point in the history

  10. Topic expiry attempt

    binwiederhier committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8eae44e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Polishing

    binwiederhier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    2329695 View commit details
    Browse the repository at this point in the history

  2. Only set rate visitor if allowed

    binwiederhier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    bfc3983 View commit details
    Browse the repository at this point in the history

  3. Release notes

    binwiederhier committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    45928dd View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Add up* length requirement

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    d5052d7 View commit details
    Browse the repository at this point in the history

  2. Return 507 for UP publishers without subscribers

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    70cd267 View commit details
    Browse the repository at this point in the history

  3. Fix 507 tests for UnifiedPush subscribe rate limiting

    @karmanyaahm
    karmanyaahm committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2f5cfab View commit details
    Browse the repository at this point in the history

  4. fix matrix tests for new error handling 

    Test driven development
    @karmanyaahm
    karmanyaahm committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fbbfa2b View commit details
    Browse the repository at this point in the history

  5. Fix Matrix errors and tests

    @karmanyaahm
    karmanyaahm committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0d7aba9 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #637 from karmanyaahm/vrate 

    Subscriber Rate Limiting Error Handling
    @binwiederhier
    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    5b5509d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:binwiederhier/ntfy into vrate

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    c108e8d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'vrate' of github.com:binwiederhier/ntfy into vrate

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    b2bedaf View commit details
    Browse the repository at this point in the history

  9. Adjust Matrix/UP behavior to work with Synapse+Mastodon

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0606fbe View commit details
    Browse the repository at this point in the history

  10. Logging fixes

    binwiederhier committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f7f343f View commit details
    Browse the repository at this point in the history