Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CellijModel class #9

Closed
martinrohbeck opened this issue Jan 25, 2023 · 5 comments
Closed

Implement CellijModel class #9

martinrohbeck opened this issue Jan 25, 2023 · 5 comments
Assignees
@martinrohbeck

Comments

@martinrohbeck
Copy link
Collaborator

The CellijModel class describes the generative model and hence implements Pyro's model() function.
@martinrohbeck martinrohbeck self-assigned this Jan 25, 2023
@martinrohbeck martinrohbeck mentioned this issue Jan 25, 2023
Closed
12 tasks
@arberqoku
Copy link
Collaborator

Should we name it CellijModel or would simply Model suffice? Since we would be calling cellij.Model, cellij.Guide.

@martinrohbeck
Copy link
Collaborator Author

Sounds good to me. I already wasn't very happy about the naming when I opened the issue 👍

@martinrohbeck martinrohbeck mentioned this issue Jan 29, 2023
Closed
@timtreis
Copy link
Collaborator

@martinrohbeck you self-assigned, but wasn't this what I should focus on next?

@martinrohbeck
Copy link
Collaborator Author

@timtreis No, ... this class here implements Pyro's model() function, which is different from the class BaseFactorModel (or however we want to name it), which is managing the overall stuff. The latter is yours.

@martinrohbeck
Copy link
Collaborator Author

First draft closed by PR #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinrohbeck martinrohbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timtreis @arberqoku @martinrohbeck