-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unicycler to v0.4.6 #10510
Update unicycler to v0.4.6 #10510
Conversation
corburn
commented
Aug 18, 2018
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
recipes/unicycler/meta.yaml
Outdated
patches: | ||
- Makefile.patch [linux] | ||
- misc.py.patch | ||
|
||
build: | ||
number: 0 | ||
skip: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could actually try to build this recipe now by overwriting the default compilers and using the new once
@corburn are you planning to work on this? |
@corburn I had a look at the errors, it seems come calls to the overload function seqan::empty are ambiguous, likely with std::empty but I'm really not sure here. Anyway, this issue could be linked to our problem, do you see a solution in there? |
@bgruening not today, but as time permits yes. I mentioned I don't yet know how to fix the recipe, but I haven't given up on it. I am comfortable with anyone working on the same recipe and submitting a successful pull request before me. If you think I should be doing something differently, please let me know. I recently found a clue why I have not been able to use the bioconda-utils-build-env docker container on my local system. The underlying image of the bioconda-utils-build-env is centos:6 which fails on my kernel: docker/for-linux#58. If the fix from one of the comments resolves the issue, it may make offline debugging easier. @PertuyF thanks for the link, I'll check it out and keep you posted. |
I looped in the seqan devs and they recommended to update to seqan 2.4. Seqan should be compatible with 2.3. so all what is needed is replacing the folder ... we should do this here in the recipe and give it a try. If it works we could upstream the changes? |
Thanks for tracking that down @bgruening. I'll fix the zlib error tomorrow. If it builds I'll send a pull request upstream. |
No idea for
Do you know where the pinning of |
anaconda.com is back and it turned green after a restart! Great work @corburn! |
Good work! @corburn |
Cool, great work |
Thanks for all the help! |