-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicycler 0.4.7 - b1 - fixes #15605
Unicycler 0.4.7 - b1 - fixes #15605
Conversation
Package(s) built on CircleCI are ready for inspection:
You may alsu use
Docker image(s) built:
|
@apeltzer please see rrwick/Unicycler#140 (comment). |
No more replacing Seqan with 2.4.0
Looks like Could you test this package and confirm you do not experience the stalling issue before we consider merging @apeltzer ? any help appreciated in testing this. |
Nice one! Thanks a bunch, I'm rebuilding my docker container for nf-core/bacass and will then start a new run to see if this changes things :-) ! |
Couple of issues: The recipe uploaded was built using python3.7: https://anaconda.org/bioconda/unicycler/files Although explicitly marked to be not built using this version? https://github.com/bioconda/bioconda-recipes/blob/master/recipes/unicycler/meta.yaml |
It could be due to python pinning at the Bioconda scale. Older versions are dropped progressively, so if python 3.6 is not supported anymore it may have forced 3.7. Is 3.7 an issue for you @apeltzer? |
Unfortunately yes :-( I'm trying to build a pipeline and many of the tools required are build with older versions of Python3.X, meaning I can't really install these in the same environment anymore due to Python3.7 being used for the new build of unicycler 0.4.7 - the old (incorrect recipe) gets installed then automatically, which breaks my pipeline due to the stalling issue mentioned above. |
One could bump all other recipes to Python3.7 however, but not sure that all of these will be built correctly then :-( |
In most cases rebuilding recipes for a new python 3.x should be painless. |
For C/C++ packages, you need to put a |
Would be great - its just a bunch of recipes though: https://github.com/nf-core/bacass/blob/092a082fb08076aed5affffe7d092b2d3d7b75a1/environment.yml |
(I think the rest is already in Python3.7 on conda-forge or bioconda) |
Are those the ones needing to be rebuilt? At least a few of them are |
Fair point - I probably should definitely update the Yes, that's the complete list of Python packages/python dependent packages. |
Yeah, the only one of those that needs rebuilding is quast. Note that that had compilation errors the last time I tried to bump everything for new pinnings, so it'll need some significant TLC. |
Quast also has a serious data package issue. Or had, last time I checked. It downloads SILVA somewhere in the middle, unpacks it, then renames the sequences and builds a BLAST index. So the package is incomplete, uses a different dataset than plain SILVA, modified in a trivial and technically uncessary manner, and breaks with clobbered data if you run it in parallel on a cluster. (end rant...) |
I am quite tempted to drop that tool just because of this. Are there alternatives that can do similar things-did a quick google search but couldn't find much unfortunately... ? |
Not that I am aware of. Double check current versions. It's not like this would be hard to fix. |
* Bump with font config for fastqc recipe * Bump miniasm once for GCC7 * Try removing the change in 0.4.6 as it introduced weird errors * Bump miniasm once for GCC7 * Try removing the change in 0.4.6 as it introduced weird errors * Remove trim_galore changes from branch * Remove miniasm changes from branch * Remove Seqan patching with 2.4.0 * Clean build.sh No more replacing Seqan with 2.4.0
This is an attempt to fix some of the weird errors seen in Unicycler 0.4.6 and 0.4.7 when using bioconda, e.g. rrwick/Unicycler#140
I tried tracking this down so far but wasn't successful until now - I think the change I removed here in the build recipe could potentially get the issue fixed as reverting to 0.4.4 is also not really an option for some people (e.g. when having/requiring multiple tools in the same container installed).