Rebuild feelnc #10725
Merged
Rebuild feelnc #10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cmonjeau
commented
Aug 28, 2018
cmonjeau
commented
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
|
Bioconda has moved to build against perl 5.26 so I think it would be better to fix dependencies that are not working. What issue did you have with perl 5.26 and feelnc? |
abretaud
reviewed
Aug 29, 2018
recipes/feelnc/meta.yaml
Outdated
| @@ -21,6 +21,7 @@ requirements: | |||
| - perl-bio-featureio | |||
|
|
|||
| run: | |||
| - perl ==5.22.0.1 | |||
There was a problem hiding this comment.
my dear @cmonjeau, can you left it as it was before? I think just rebuilding should be enough
BUT you'll need to remove feelnc from the blacklist https://github.com/bioconda/bioconda-recipes/blob/master/build-fail-blacklist#L1964
bgruening
reviewed
Aug 29, 2018
| @@ -15,7 +15,6 @@ build: | |||
|
|
|||
| requirements: | |||
| build: | |||
| - perl ==5.22.0.1 | |||
There was a problem hiding this comment.
perl should be given if perl is needed. This is a special case afaik for all scripting languages. Some for R or python.
There was a problem hiding this comment.
ok, good to know, I wasn't 100% sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.