Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pairix Python 3.8 #25030

Closed
wants to merge 9 commits into from
Closed

pairix Python 3.8 #25030

wants to merge 9 commits into from

Conversation

joachimwolff
Copy link
Contributor

Test to see if increasing the build number leads to a Python 3.8 version.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@simonbray
Copy link
Member

@bioconda-bot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot
Copy link
Collaborator

I received an error uploading the build artifacts or merging the PR!

@simonbray
Copy link
Member

Nooooooooooo :(

@joachimwolff joachimwolff changed the title [WIP] pairix Python 3.8 pairix Python 3.8 Oct 27, 2020
@simonbray
Copy link
Member

@bioconda-bot please upload artifacts

@lldelisle
Copy link
Contributor

@joachimwolff both sed -e '/CC=/s/^/#/g' -i src/Makefile and sed -e '/CFLAGS=/s/^/#/g' -i src/Makefile put # in front of line 22, then sed -i '/CC="/s/^#//g' src/Makefile remove only one of them.
I propose:

sed -e '/^CC=/s/^/#/g' -i src/Makefile
sed -e '/^CFLAGS=/s/^/#/g' -i src/Makefile

Which will only affect the first lines, not the line 22.

@simonbray
Copy link
Member

You can also make a patch file if this is easier than using sed

@joachimwolff
Copy link
Contributor Author

I give up to fix this, maybe someone with more experience with the conda build system and gcc can help.

@joachimwolff
Copy link
Contributor Author

Closing, see #25052.

@bgruening bgruening deleted the joachimwolff-patch-2 branch July 31, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants