-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targetscan_70.pl
#37960
Add targetscan_70.pl
#37960
Conversation
@BiocondaBot please fetch artifacts |
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
@BiocondaBot please add label |
|
||
extra: | ||
skip-lints: | ||
- license_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license is not really optional. There needs to be a license in place that allows redistribution- see the checklist at https://bioconda.github.io/contributor/guidelines.html#bioconda-recipe-checklist.
version: {{ version }} | ||
|
||
source: | ||
url: https://www.targetscan.org/vert_80/vert_80_data_download/targetscan_70.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URI should refer to the version - you can change it to remove the full stop- see example.
#!/usr/bin/env bash | ||
|
||
mkdir -p $PREFIX/bin | ||
cp targetscan_70.pl $PREFIX/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a bunch of other Perl scripts at https://www.targetscan.org/cgi-bin/targetscan/data_download.vert80.cgi you could have included.
But I do think the license is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to create a PR for the perl module Bio::TreeIO for the subsequent targetscan scripts to work, I can try to 'paint by numbers' using the multiple examples of perl modules in the recipes directory.
Regarding the license file, I honestly cannot find one. I've searched their 8 publications to no avail, all I can glean is this info from their executable: Copyright (c) The Whitehead Institute of Biomedical Research
.
I never got the sense Targetscan is proprietary, it is routinely used in papers that use miRNA prediction. Perhaps this is a result of the tool being developed in 2005. Alas... let me know your gut feeling, I can open a discussion on nf-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not one of the core Bioconda people, but IMO I don't think this is going to fly without an appropriate license. You should ask on the Bioconda gitter in case I'm wrong (this isn't really an nf-core issue).
@BiocondaBot please fetch artifacts We're not terribly strict when it comes to licenses, they apparently mean for it to be redistributable at least. |
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
@BiocondaBot please merge |
Sorry, this PR cannot be merged at this time. |
@BiocondaBot please merge |
Sorry, this PR cannot be merged at this time. |
@BiocondaBot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Merge PR bioconda#37960, commits were: * Merge branch 'master' into targetscan * targetscan_70.pl help test * TS_70
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.