Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetscan_70.pl #37960

Merged
merged 3 commits into from
Nov 19, 2022
Merged

Add targetscan_70.pl #37960

merged 3 commits into from
Nov 19, 2022

Conversation

BarryDigby
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@BarryDigby BarryDigby mentioned this pull request Nov 14, 2022
6 tasks
@BarryDigby
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
noarch targetscan-7.0-pl5321hdfd78af_0.tar.bz2 LinuxArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images are in the LinuxArtifacts zip file above):

Package Tag Install with docker
targetscan 7.0--pl5321hdfd78af_0
showgzip -dc LinuxArtifacts/images/targetscan:7.0--pl5321hdfd78af_0.tar.gz | docker load

@BarryDigby
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Nov 15, 2022

extra:
skip-lints:
- license_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license is not really optional. There needs to be a license in place that allows redistribution- see the checklist at https://bioconda.github.io/contributor/guidelines.html#bioconda-recipe-checklist.

version: {{ version }}

source:
url: https://www.targetscan.org/vert_80/vert_80_data_download/targetscan_70.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URI should refer to the version - you can change it to remove the full stop- see example.

#!/usr/bin/env bash

mkdir -p $PREFIX/bin
cp targetscan_70.pl $PREFIX/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of other Perl scripts at https://www.targetscan.org/cgi-bin/targetscan/data_download.vert80.cgi you could have included.

But I do think the license is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to create a PR for the perl module Bio::TreeIO for the subsequent targetscan scripts to work, I can try to 'paint by numbers' using the multiple examples of perl modules in the recipes directory.

Regarding the license file, I honestly cannot find one. I've searched their 8 publications to no avail, all I can glean is this info from their executable: Copyright (c) The Whitehead Institute of Biomedical Research.

I never got the sense Targetscan is proprietary, it is routinely used in papers that use miRNA prediction. Perhaps this is a result of the tool being developed in 2005. Alas... let me know your gut feeling, I can open a discussion on nf-core.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not one of the core Bioconda people, but IMO I don't think this is going to fly without an appropriate license. You should ask on the Bioconda gitter in case I'm wrong (this isn't really an nf-core issue).

@dpryan79
Copy link
Contributor

@BiocondaBot please fetch artifacts

We're not terribly strict when it comes to licenses, they apparently mean for it to be redistributable at least.

@BiocondaBot
Copy link
Collaborator

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
noarch targetscan-7.0-pl5321hdfd78af_0.tar.bz2 LinuxArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images are in the LinuxArtifacts zip file above):

Package Tag Install with docker
targetscan 7.0--pl5321hdfd78af_0
showgzip -dc LinuxArtifacts/images/targetscan:7.0--pl5321hdfd78af_0.tar.gz | docker load

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

Sorry, this PR cannot be merged at this time.

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

Sorry, this PR cannot be merged at this time.

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit b79a43a into bioconda:master Nov 19, 2022
cokelaer pushed a commit to cokelaer/bioconda-recipes that referenced this pull request Apr 28, 2023
Merge PR bioconda#37960, commits were: 
 * Merge branch 'master' into targetscan
 * targetscan_70.pl help test
 * TS_70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants