Update usher: don't skip on Mac OSX #38446
Conversation
AngieHinrichs
force-pushed
the
usher.v0.6.mac
branch
from
db995ea
to
dbc4ddb
Compare
AngieHinrichs
force-pushed
the
usher.v0.6.mac
branch
from
dbc4ddb
to
3d212eb
Compare
|
@BiocondaBot please add label |
|
It's a bit confusing for users I guess. That the same package with same versions has different binaries. It might be confusing for users and hard to debug. Can we maybe add a pseudo binary that prints a meaningful error message? |
Yes, it's not a very satisfying solution and is just a short-term measure to get usher v0.6.1 to build on Mac so that Mac users can have the amazing new usher-sampled program, which will make pangolin run a lot faster. So far there has been some interest in ripples and ripples-fast, but nobody has complained yet about ripples-fast not being available on Mac. 🙂 But pangolin has a lot of users and is a very high priority for us. Hopefully soon we'll find out how to include the right headers in the bioconda Mac build environment so we can use Intel SIMD instructions like Thanks @bgruening! |
…script that prints out a message pointing to yatisht/usher#310.
|
@bgruening I updated build.sh to make a placeholder script version of ripples-fast when skipping it in the build, that prints out this message: |
|
Thanks @rpetit3! Is anything else needed for a merge? |
|
Happy New Year Bioconda team! Can this be merged, so that pangolin can use the new faster usher-sampled on Mac as well as linux? Thanks! |
|
@BiocondaBot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
|
I received an error uploading the build artifacts or merging the PR! |
|
@BiocondaBot please update |
|
@BiocondaBot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Merge PR bioconda#38446, commits were: * Merge remote-tracking branch 'upstream/master' into usher.v0.6.mac * When not building ripples-fast on Mac, add a stub ripples-fast shell script that prints out a message pointing to yatisht/usher#310. * Don't skip Mac build for usher; instead, omit ripples-fast when building on Mac.
Don't skip Mac build for usher; instead, omit ripples-fast if architecture is not x86_64.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please mergeSomeone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.