Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GTDB-tk recipe #40333

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Update GTDB-tk recipe #40333

merged 2 commits into from
Apr 10, 2023

Conversation

rpetit3
Copy link
Member

@rpetit3 rpetit3 commented Apr 9, 2023

Conda is not available on the containers. So, if downloading from a container the script will exit with code 1, even though the download finished.

This PR makes it so that the user will receive a warning for missing conda. This atleast allows the containers to play nice with workflow managers


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@rpetit3 rpetit3 requested a review from aaronmussig April 9, 2023 05:31
@rpetit3
Copy link
Member Author

rpetit3 commented Apr 10, 2023

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Apr 10, 2023
@bgruening bgruening merged commit 24edf2f into bioconda:master Apr 10, 2023
@rpetit3 rpetit3 deleted the rp3-update-gtdbtk branch April 10, 2023 22:35
cokelaer pushed a commit to cokelaer/bioconda-recipes that referenced this pull request Apr 28, 2023
* Update download-db.sh in GTDBtk

* Update meta.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants