Statistical power #127
Statistical power #127
Conversation
Removes collection season
- fixes equation formatting - fixes spelling errors - removes checkpoint files - adds link to alpha diversity
Data now corresponds to whats provided in the power pull request
(Images are updated to power branch, which hasn’t been merged, yet.)
|
@wasade, I've updated the code as per your suggestions and added the new text to the notebook. |
|
|
||
| # Prevents the confidence interval of being less than 0 or more than 1 | ||
| pwr_lower = pwr_mean - pwr_bound | ||
| np.where(pwr_lower < 0, 0, pwr_lower) |
There was a problem hiding this comment.
This is not an inplace operation, so this doesn't have an effect. What you want here is pwr_lower = np.where(pwr_lower < 0, 0, pwr_lower).
Have the changes made on the last round of commits been verified they work as expected?
|
Still a few typos I saw with 'significance', and the |
|
@ElDeveloper, were you able to go over the other notebook by chance? |
|
No, I wasn't able to go over the other notebook. On (Mar-05-15|15:57), Daniel McDonald wrote:
|
|
Just on a quick pass through, the rendered notebook still has grammar and spelling issues to be resolved. Where the suggestions that @cuttlefishh and @EmbrietteH made to the google doc merged in? |
|
Possible to do so? On Thu, Mar 5, 2015 at 5:00 PM, Yoshiki Vázquez Baeza <
|
|
I tested the code by running it through both notebooks, and the test suite. |
|
From what I'm seeing, the notebook text does not appear to be in sync with On Thu, Mar 5, 2015 at 5:12 PM, J W Debelius notifications@github.com
|
|
That is the updated notebook and text. What I'm seeing lines up with the On Thu, Mar 5, 2015 at 4:17 PM, Daniel McDonald notifications@github.com
|
|
This is the reason why I can't comment on the notebook: GitHub will not show the interface for me to make comments on it. On (Mar-05-15|16:10), Daniel McDonald wrote:
|
|
@jwdebelius, please see the screenshots below. There are others as well @ElDeveloper, able to comment separate from inline on github? It's not ideal, but we need to review the material somehow
|
*Redirect works, but the analysis was run with a table already processed for rounds 1-14
|
I've updated. I can ask someone else to check through spelling again before you give another pass. Also, I processed the data for the alpha diversity on a pre-computed tables, since the current maps are missing preceding zeros. This skips the download step, since the notebook requires the github directory, but assumes the kernel is running in the ipnyb directory. |
|
Thanks. I'm going to do one more pass through today. I think we're nearly or already there, so it should go quick. And its not like we can't issue future PRs to update if necessary anyway. Thank you for all the hard work on this!! |
|
I asked an extra person to look through it. I thought they'd be done tonight, but they sent me a couple more edits that I'm working on now. Sorry for the lengthy process. |
Hopefully this is the last round
|
Okay, I got the new stuff in, too. Should be good. |
|
Sorry, didn't see the comment until now. Reviewing |
|
I think this is good, thanks @jwdebelius!!!! |
This is a cleaned up power notebook, loosely related to what was presented in #121
The rendered notebook can be found here.
The text is in Google docs, which may be a better place for text editing.
This notebook relies on code generated in #125 and on the data files generated when #126 is run.