1 get sequences and metadata #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uences_and_metadata Conflicts: .travis.yml
|
This first PR for #161 is large as it brings over the infrastructure that was necessary for the other notebooks that had been developed. It would have been really painful to slice up the python modules. But, once this is merged, the other notebooks will have much less burden associated. |
|
@ElDeveloper @josenavas @squirrelo @mortonjt or @antgonza, possible for a review? |
| path : str | ||
| A path that does not exist | ||
|
|
||
| Notes |
There was a problem hiding this comment.
The Notes should be after the Returns, right?
|
few comments and questions. |
| @@ -2,22 +2,30 @@ language: python | |||
| env: | |||
| - PYTHON_VERSION=2.7 | |||
| before_install: | |||
| - wget http://repo.continuum.io/miniconda/Miniconda3-3.7.3-Linux-x86_64.sh -O miniconda.sh | |||
| - wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O miniconda.sh | |||
|
Missed one instance of I promise the next set of notebooks will be much lighter, at least until we get to the per-sample stuff in notebook 8 |
|
👍 |
|
merge? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the first few points in #161