-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter sequences for blooms #163
filter sequences for blooms #163
Conversation
* Filter demultiplexed sequence data to only fecal samples | ||
* Determine what sequences in the fecal samples recruit to the observed bloom sequences | ||
* Remove the recruited bloom sequences from the demultiplexed sequence data | ||
* Trim the filtered demultiplexed data (to reduce study bias when combining with short reads, such as the data in [Yatsunenko et al 2012](http://www.nature.com/nature/journal/v486/n7402/abs/nature11053.html)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in a separate md? Note that this is not part of the bloom filtering ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, copy pasta. Trimming is done in the pick OTUs step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want pasta, it's almost lunch time ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually done in this notebook at the end. i dont see the benefit in a notebook dedicated to trimming though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, saw that. Perhaps adding to the main description. Note that it talks about the bloom filtering but not about the length.
A few comments ... nothing major. |
Thanks! On Wed, Oct 21, 2015 at 1:35 PM, Antonio Gonzalez notifications@github.com
|
I don't see any immediate problems. Is this ready to merge? |
If @antgonza gives a 👍 |
thanks! On Wed, Oct 21, 2015 at 2:27 PM, Antonio Gonzalez notifications@github.com
|
@ElDeveloper @antgonza @mortonjt @josenavas @squirrelo, round 2 is up.