Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter sequences for blooms #163

Merged
merged 3 commits into from
Oct 21, 2015

Conversation

wasade
Copy link
Member

@wasade wasade commented Oct 21, 2015

* Filter demultiplexed sequence data to only fecal samples
* Determine what sequences in the fecal samples recruit to the observed bloom sequences
* Remove the recruited bloom sequences from the demultiplexed sequence data
* Trim the filtered demultiplexed data (to reduce study bias when combining with short reads, such as the data in [Yatsunenko et al 2012](http://www.nature.com/nature/journal/v486/n7402/abs/nature11053.html))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in a separate md? Note that this is not part of the bloom filtering ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, copy pasta. Trimming is done in the pick OTUs step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want pasta, it's almost lunch time ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually done in this notebook at the end. i dont see the benefit in a notebook dedicated to trimming though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, saw that. Perhaps adding to the main description. Note that it talks about the bloom filtering but not about the length.

@antgonza
Copy link
Contributor

A few comments ... nothing major.

@wasade
Copy link
Member Author

wasade commented Oct 21, 2015

Thanks!

On Wed, Oct 21, 2015 at 1:35 PM, Antonio Gonzalez notifications@github.com
wrote:

A few comments ... nothing major.


Reply to this email directly or view it on GitHub
#163 (comment).

@mortonjt
Copy link
Contributor

I don't see any immediate problems. Is this ready to merge?

@wasade
Copy link
Member Author

wasade commented Oct 21, 2015

If @antgonza gives a 👍

antgonza added a commit that referenced this pull request Oct 21, 2015
@antgonza antgonza merged commit c73b074 into biocore:master Oct 21, 2015
@wasade
Copy link
Member Author

wasade commented Oct 21, 2015

thanks!

On Wed, Oct 21, 2015 at 2:27 PM, Antonio Gonzalez notifications@github.com
wrote:

Merged #163 #163.


Reply to this email directly or view it on GitHub
#163 (comment).

@wasade wasade mentioned this pull request Oct 21, 2015
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants