Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 collapse samples #169

Merged
merged 8 commits into from Oct 24, 2015
Merged

8 collapse samples #169

merged 8 commits into from Oct 24, 2015

Conversation

wasade
Copy link
Member

@wasade wasade commented Oct 22, 2015

depends on #166, #167, #168

>>> ag_100nt_1k_skin_age_biom = agu.get_new_path(agenv.paths['ag-100nt-1k-skin-age-biom'])
>>> ag_100nt_1k_skin_hand_biom = agu.get_new_path(agenv.paths['ag-100nt-1k-skin-hand-biom'])
...
>>> ignored = 'foo'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a placeholder for future use? It's only set here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a comment if you'd like, but there was a file path that was necessary for the call but not used after the fact

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah a comment would be good.

@squirrelo
Copy link
Contributor

Just one comment.

@wasade
Copy link
Member Author

wasade commented Oct 24, 2015

merge?

squirrelo added a commit that referenced this pull request Oct 24, 2015
@squirrelo squirrelo merged commit dd16cf8 into biocore:master Oct 24, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 323c9f4 on wasade:8-collapse_samples into ** on biocore:master**.

@josenavas
Copy link
Member

@coveralls

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants