Merge pull request #33 from biocore/fix_eigen_order

fix eigenvalues order issue
biocore · Apr 16, 2019 · eb392a4 · eb392a4
2 parents 41278a3 + 5325a45
commit eb392a4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # DEICODE changelog
 
+## Version 0.2.1 (2019-4-15)
+
+Implemented in [PR#33](https://github.com/biocore/DEICODE/pull/33).
+
+### Bug fixes
+
+* Eigenvalues were out of order, single line problem in optspace.py
+
 ## Version 0.2.0 (2019-4-8)
 
 Implemented in [PR#29](https://github.com/biocore/DEICODE/pull/29).

diff --git a/deicode/__init__.py b/deicode/__init__.py
@@ -8,4 +8,4 @@
 #
 # ----------------------------------------------------------------------------
 
-__version__ = "0.2.0"
+__version__ = "0.2.1"
diff --git a/deicode/optspace.py b/deicode/optspace.py
@@ -180,7 +180,7 @@ def _fit(self):
                                niter=self.iteration, tol=self.tol)
         solution = U.dot(s_).dot(V.T)
         explained_variance_ratio_ = np.diag(s_) / np.diag(s_).sum()
-        self.eigenvalues = np.diag(s_)
+        self.eigenvalues = np.diag(s_)[::-1]
         self.explained_variance_ratio = list(explained_variance_ratio_)[::-1]
         self.distance = distance.cdist(U, U)
         self.solution = solution