fix eigenvalues order issue #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortonjt
reviewed
Apr 15, 2019
| @@ -180,7 +180,7 @@ def _fit(self): | |||
| niter=self.iteration, tol=self.tol) | |||
| solution = U.dot(s_).dot(V.T) | |||
| explained_variance_ratio_ = np.diag(s_) / np.diag(s_).sum() | |||
| self.eigenvalues = np.diag(s_) | |||
| self.eigenvalues = np.diag(s_)[::-1] | |||
| self.explained_variance_ratio = list(explained_variance_ratio_)[::-1] | |||
There was a problem hiding this comment.
that's the culprit -- reversed one line, but not the other 😆
There was a problem hiding this comment.
@mortonjt Yes, a sneaky little bug snuck right by me. Thanks for pointing out!
There was a problem hiding this comment.
This is probably ok for now -- but the longterm solution is to sort all of the eigenvalues, then np.argsort all of the columns in the samples and features.
This will require a larger unittest with say 5 dimensions. Can push PR later.
mortonjt
approved these changes
Apr 15, 2019
|
Thanks for the quick fix @cameronmartino ! |
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line change with out of order eigenvalues. Bug fix for #32 .