This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
Unittest ag pulldown #119
Merged
Unittest ag pulldown #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttest_ag_pulldown
2) added @authenticated decorator to a get method to restrict access 3) if no barcode file is given and the user hits "submit" nothing happend. I now return a message to the user to inform him about the missing file.
wasade
reviewed
Sep 23, 2016
|
|
||
| class testUpdateEBIStatusHandler(TestHandlerBase): | ||
| def test_get_not_authed(self): | ||
| os.environ["ASYNC_TEST_TIMEOUT"] = "30" |
There was a problem hiding this comment.
would it make sense for this to be done once at the module level?
There was a problem hiding this comment.
I don't know how :-/
wasade
reviewed
Sep 23, 2016
|
|
||
| class testAGPulldownDLHandler(TestHandlerBase): | ||
| def test_get_not_authed(self): | ||
| # os.environ["ASYNC_TEST_TIMEOUT"] = "30" |
|
Two minor comments, 👍 otherwise |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.