merge snakemake rules and add msa_size info to index #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanssen2
approved these changes
Sep 26, 2017
| @@ -107,130 +107,115 @@ def split_x(inp_0, out_0, step="NA", version=config['VERSION'], | |||
| shell('echo "pass" > {out_0}') | |||
|
|
|||
|
|
|||
| def copy_out(source_dir='01-PDB', dest_dir='PDB', tempdir='/dev/null'): | |||
There was a problem hiding this comment.
do we want to copy or can we move to same space? How about softlinks to avoid redundancy?
There was a problem hiding this comment.
this function is used to copy from localscratch to the main filesystem, hence the use of rsync to package the data on its way.
so softlinks are a no-go and move = copy+delete, hence it's not needed because I do a bulk clean-up later on.
|
It would be nice to have unit tests for the snakemake_helper functions! |
|
agree re unit tests. I need to do this soon and will issue a separate PR to address. |
qiyunzhu
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #48 and #52