Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_validator #1972

Merged
merged 2 commits into from
Oct 17, 2016
Merged

get_validator #1972

merged 2 commits into from
Oct 17, 2016

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 91.358% when pulling 4a2adf5 on antgonza:get_validator into fe5e4dc on biocore:master.

Copy link
Contributor

@josenavas josenavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments


Raises
------
qdb.exceptions.QiitaDBError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation on when is this error raised?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

res = qdb.sql_connection.TRN.execute_fetchlast()
except IndexError:
raise qdb.exceptions.QiitaDBError(
"There is no command to generate the Validate for "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Validate command...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather leave as is as: "There is no command to generate the Validate command" sounds weird ...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 91.348% when pulling 9608bf6 on antgonza:get_validator into fe5e4dc on biocore:master.

@josenavas josenavas merged commit 66d5e4b into qiita-spots:master Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants