Fixing bug with summary jobs #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
reviewed
Dec 16, 2016
| @@ -448,7 +458,9 @@ def test_complete_success(self): | |||
| alljobs = set(self._get_all_job_ids()) | |||
|
|
|||
| job.complete(True, artifacts_data=artifacts_data) | |||
| self.assertTrue(job.status, 'success') | |||
| # The validator job spawn blocks this job in running state until | |||
There was a problem hiding this comment.
Can you rewrite this? Is not really clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while developing the qtp-biom plugin. Basically, the "Generate HTML summary" jobs do not generate new artifacts. This bug was not affecting any functionality per se, but it was leaving jobs in the DB in the "runnning" state although they successfully completed.
Added a specific test for this issue.