Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1609 #2034

Merged
merged 2 commits into from
Jan 4, 2017
Merged

fix #1609 #2034

merged 2 commits into from
Jan 4, 2017

Conversation

antgonza
Copy link
Member

Turns out that the fix was easier than expected.

Now it looks like this with just the alert message:
Example 1:
screen shot 2016-12-27 at 8 17 18 pm
Example 2:
screen shot 2016-12-27 at 8 17 03 pm
and with the extra message:
screen shot 2016-12-27 at 8 16 53 pm
and adding samples to analysis:
screen shot 2016-12-27 at 8 17 51 pm

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.496% when pulling 965c976 on antgonza:fix-1609 into 103e0e5 on biocore:master.

wasade
wasade reviewed Jan 3, 2017
View reviewed changes
qiita_pet/templates/sitebase.html
{% end %}
{% set message = globals().get('message', '') %}
{% if maintenance is not None %}
{# maintenance mode takes precidence #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precedence

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 91.504% when pulling a929923 on antgonza:fix-1609 into 103e0e5 on biocore:master.

@josenavas josenavas merged commit 9c474c8 into qiita-spots:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasade wasade wasade left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antgonza @coveralls @wasade @josenavas