Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1505 #2036

Merged
merged 6 commits into from
Jan 16, 2017
Merged

Fix 1505 #2036

merged 6 commits into from
Jan 16, 2017

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Jan 3, 2017

This is the graphical part of #2035 so review that one first. This has been deployed in the test environment. After review there we should discuss:

  • displaying all jobs is basically useless/impossible(?) for admins, should we always display only the latests 10 jobs? ===> 30, and avoid displaying successful jobs
  • some jobs don't have workflows so deleting via workflows is not always possible. We could add deletion of jobs via workflows, even if the workflow doesn't exist or differentiate between the jobs that have a workflow or not - I like the first option ==> as we can only remove jobs in_construction, all those jobs have a workflow; not a problem anymore.
  • how often should we "refresh" the page, currently 1 second ===> 30 seconds
  • some of the jobs don't have heartbeat, what should we do? ===> they don't have a heartbeat cause they are not running.
  • error messages are only displayed on reload, thus not showed with this new code. ==> review
  • the GUI ==> remove params and just display when on top

Note that here I'm adding vue.min.js and it's fully used by the new GUI, which we should also discuss where we want to use.

The example:
qiita-processingjob

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3601c29 on antgonza:fix-1505 into ** on biocore:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0d6788e on antgonza:fix-1505 into ** on biocore:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 12406cc on antgonza:fix-1505 into ** on biocore:master**.

@josenavas
Copy link
Contributor

@antgonza merge conflicts here, but I think we are talking about this PR today during the meeting?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.51% when pulling 958fcbe on antgonza:fix-1505 into 46b7d0b on biocore:master.

@antgonza
Copy link
Member Author

antgonza commented Jan 5, 2017

This is ready for another review, all comments addressed. Main changes:

  • Only updates the jobs when the div is shown, see the small delay to show the list in the example below
  • Update every 30 secs
  • Only refreshes the view if the data actually changes
  • Fixed issues and followed GUI recommendations discussed in today's meeting
  • Delete button only on those jobs that can be deleted.

Example from qiita-test deploy:
qiita-processingjob

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 91.516% when pulling 2ead7a6 on antgonza:fix-1505 into 46b7d0b on biocore:master.

@antgonza
Copy link
Member Author

@josenavas, could you review?

@josenavas josenavas merged commit e64a22a into qiita-spots:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants