Adding tags #2088
Adding tags #2088
Conversation
|
@biocore/qiita-admin, wanna take a look/review? |
qiita_db/study.py
Outdated
| @@ -1152,6 +1137,75 @@ def unshare(self, user): | |||
| qdb.sql_connection.TRN.add(sql, [self._id, user.id]) | |||
| qdb.sql_connection.TRN.execute() | |||
|
|
|||
| def add_tags(self, user, tags): | |||
There was a problem hiding this comment.
Should this be named update_tags, given that it can add and remove tags?
qiita_db/study.py
Outdated
| Parameters | ||
| ---------- | ||
| user: User object | ||
| The user to unshare the study with |
qiita_db/study.py
Outdated
| user: User object | ||
| The user to unshare the study with | ||
| tags : list of str | ||
| The tags to add to the study |
There was a problem hiding this comment.
The tags to attach to the study - or something along those lines (since it is not only adding)
qiita_db/study.py
Outdated
| if user_level != 'admin': | ||
| admin_tags = to_add & system_tags_admin | ||
| if admin_tags: | ||
| message += ('Only admins can assing: ' |
|
Seems reasonable |
qiita_db/study.py
Outdated
| @@ -1152,6 +1137,75 @@ def unshare(self, user): | |||
| qdb.sql_connection.TRN.add(sql, [self._id, user.id]) | |||
| qdb.sql_connection.TRN.execute() | |||
|
|
|||
| def add_tags(self, user, tags): | |||
qiita_db/study.py
Outdated
| Parameters | ||
| ---------- | ||
| user: User object | ||
| The user to unshare the study with |
qiita_db/study.py
Outdated
| user: User object | ||
| The user to unshare the study with | ||
| tags : list of str | ||
| The tags to add to the study |
qiita_db/study.py
Outdated
| if user_level != 'admin': | ||
| admin_tags = to_add & system_tags_admin | ||
| if admin_tags: | ||
| message += ('Only admins can assing: ' |
qiita_db/study.py
Outdated
| @@ -1152,6 +1137,75 @@ def unshare(self, user): | |||
| qdb.sql_connection.TRN.add(sql, [self._id, user.id]) | |||
| qdb.sql_connection.TRN.execute() | |||
|
|
|||
| def updata_tags(self, user, tags): | |||
| self.assertEqual(response.code, 200) | ||
| self.assertEqual(response.body, exp) | ||
|
|
||
| def test_patch(self): |
There was a problem hiding this comment.
same question as in #2092, should there be negative tests?
There was a problem hiding this comment.
I don't think is required as all possible options are tested here: https://github.com/biocore/qiita/pull/2088/files#diff-a0b367a8e2e2e1d72fee16533d797415R541, what do you think?
There was a problem hiding this comment.
I think this is logically distinct. The goal of a negative test here, and with test_get, is to verify the status codes and response messages are rational for malformed or inappropriate REST requests
Based on reviews during the Qiita meeting, I'm changed the way this feature works. You can see how it works in the attachment below. Another big change from original definition is that now we are using REST calls to get the tags and the updates.
Note that this adds the possibility of adding tags to studies and keeping track of them by user. However, we are still not showing or filtering the studies in the study list by this. I'll make another PR adding that functionality as this PR is pretty long (but not terrible) already.