More fixes on the Qiita(Status)Object classes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| if not self._check_id(id_): | ||
| raise QiitaDBObjectDoesNotExistsError(id_, self._table) |
There was a problem hiding this comment.
That is a hugely long error name.
There was a problem hiding this comment.
Yup, I had the same feeling. Do we actually need to prefix the error with QiitaDB? Then we can have:
ObjectDoesNotExistsError, which is a bit better...
There was a problem hiding this comment.
Thinking a bit more, QiitaDBUnknownIDError looks better...
|
A few comments, overall looks good. |
|
Thanks @squirrelo I've solved your comments. |
|
Seems good |
|
looks like we have 2 👍 can somebody take a quick look and merge? |
antgonza
added a commit
that referenced
this pull request
Jun 9, 2014
More fixes on the Qiita(Status)Object classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes on the QiitaObject and QiitaStatusObject base classes:
__init__on the QiitaObject class now checks that theidpassed actually belongs to an object in the database._status_setter_checksthat should be overwritten by the subclasses in order to perform the necessary checks before updating the DB object.check_statusdecorator was not working. Rewriting it to be just a boolean function, so subclasses can call it when needed.It would be great if this can be in soon, as it should be merged before any other object is merged.