NimaGen 29-plex #134
Merged
NimaGen 29-plex #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standage
commented
Aug 18, 2023
| markers = sorted(interval.data, key=lambda m: m.sortkey) | ||
| markers = sorted(interval.data, key=lambda m: m.sources[0].sortkey) |
There was a problem hiding this comment.
Fixing a bug that was introduced in #133.
Comment on lines
+182
to
+189
| def rsid_union(self, *others): | ||
| rsids = set(self.rsids) | ||
| for other in others: | ||
| rsids |= set(other.rsids) | ||
| for rsid in rsids: | ||
| for marker in chain([self], others): | ||
| if rsid not in marker.rsids: | ||
| marker.rsids.append(rsid) |
There was a problem hiding this comment.
Some markers are defined only using positions, no RSIDs. Some of these are exact matches for markers with some or all RSIDs defined. This function merges RSID lists when markers are merged during the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds definitions for 29 markers from NimaGen's (currently beta) microhap kit.