Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Magic Number #73

Closed
nathanhaigh opened this issue Mar 29, 2017 · 1 comment
Closed

CSI Magic Number #73

nathanhaigh opened this issue Mar 29, 2017 · 1 comment

Comments

@nathanhaigh
Copy link

nathanhaigh commented Mar 29, 2017

I've been having a look at the CSI specs and your code. Shouldn't the magic number for CSI be:

var csiMagic = [4]byte{'C', 'S', 'I', 0x1}

instead of:

var csiMagic = [3]byte{'C', 'S', 'I'}

Here: https://github.com/biogo/hts/blob/master/csi/csi.go#L16

@kortschak
Copy link
Member

The CSI magic number is version-dependent. CSIv1 is "CSI\x01", CSIv2 is "CSI\x02". The number is written out programmatically rather than from a constant, and read similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants