Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImplicitOutputShape is not properly validated?! #158

Closed
constantinpape opened this issue Nov 23, 2021 · 2 comments
Closed

ImplicitOutputShape is not properly validated?! #158

constantinpape opened this issue Nov 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@constantinpape
Copy link
Contributor

We specify that shape = shape(input_tensor) * scale + 2 * offset for the ImplicitOutputShape, see https://github.com/bioimage-io/spec-bioimage-io/blob/gh-pages/model_spec_latest.md.
However, it seems like this is not properly checked in bioiamgeio test-model:
test-model passes for https://github.com/bioimage-io/spec-bioimage-io/blob/main/example_specs/models/stardist_example_model/rdf.yaml#L39; however, the correct value would be 33 / 2.
@FynnBe we should make sure that the ImplicitOutputShape (and also InputShape etc.) are validated for the test input / outputs.
Is test-model the best place to do this or can we do it even earlier in validation?

@FynnBe
Copy link
Member

FynnBe commented Nov 23, 2021

after "offline" discussion:
in bioimageio validate we do not test if the specified files even exist. For simplicity we should keep it that way, which avoids any trouble running the validate command in pyodide, etc.
Therefore I will add the check for shape matching of test data and description to bioimageio test-model here in core.

@FynnBe
Copy link
Member

FynnBe commented Nov 23, 2021

in the docs we do not specify how we round the shape(input_tensor) * scale part? numpy.round_() to dodge the specifics on our side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants